Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF 2.0 docs] Add example for EarlyStopping #27838

Merged
merged 6 commits into from
May 1, 2019

Conversation

aweers
Copy link
Contributor

@aweers aweers commented Apr 14, 2019

I think a short example like this is very useful for user who don't have much experience and want to use a callback for their first time.

I think a short example like this is very useful for user who don't have much experience and want to use a callback for their first time.
@aweers
Copy link
Contributor Author

aweers commented Apr 14, 2019

If the responses are positive I will create examples for the other callbacks, too. ;)

Copy link
Contributor

@kyscg kyscg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @aweers

I tried to make the comments interactive. Change these and keep going

Cheers!!!

tensorflow/python/keras/callbacks.py Outdated Show resolved Hide resolved
tensorflow/python/keras/callbacks.py Outdated Show resolved Hide resolved
tensorflow/python/keras/callbacks.py Outdated Show resolved Hide resolved
tensorflow/python/keras/callbacks.py Outdated Show resolved Hide resolved
Co-Authored-By: aweers <32593524+aweers@users.noreply.github.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

kyscg and others added 3 commits April 14, 2019 22:04
Co-Authored-By: aweers <32593524+aweers@users.noreply.github.com>
Co-Authored-By: aweers <32593524+aweers@users.noreply.github.com>
Co-Authored-By: aweers <32593524+aweers@users.noreply.github.com>
@aweers
Copy link
Contributor Author

aweers commented Apr 14, 2019

Thank you again @kyscg! I like the interactive style and will try to make the next examples in a similiar way!

kyscg
kyscg previously approved these changes Apr 15, 2019
@kyscg
Copy link
Contributor

kyscg commented Apr 15, 2019

@rthadur, gentle ping to review and set CLA's to yes

@rthadur
Copy link
Contributor

rthadur commented Apr 15, 2019

@aweers can you please sign CLA

@rthadur rthadur self-assigned this Apr 15, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 15, 2019
@rthadur rthadur added size:S CL Change Size: Small comp:keras Keras related issues labels Apr 15, 2019
@aweers
Copy link
Contributor Author

aweers commented Apr 15, 2019

@rthadur I signed the CLA ;)

@rthadur rthadur added cla: yes and removed cla: no labels Apr 15, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@rthadur rthadur requested a review from rchao April 15, 2019 21:31
@kyscg
Copy link
Contributor

kyscg commented Apr 22, 2019

@rthadur @rchao Gentle ping to review

Copy link
Contributor

@rchao rchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please see the comments.

@aweers
Copy link
Contributor Author

aweers commented Apr 22, 2019

@rchao I updated the file with your suggestions

@aweers
Copy link
Contributor Author

aweers commented Apr 22, 2019

But somehow I don't see a new commit? Only if I try to edit the file again, I see the changes I made...

@rchao
Copy link
Contributor

rchao commented Apr 22, 2019

But somehow I don't see a new commit? Only if I try to edit the file again, I see the changes I made...

Thanks! I don't see it either. Please let me know once the commit is made.

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Apr 22, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@aweers
Copy link
Contributor Author

aweers commented Apr 23, 2019

@rchao @rthadur now the commit is made, don't know why it took some time... But CLA check failed again, so it need to be set by you ;)

@rthadur rthadur added cla: yes and removed cla: no labels Apr 23, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Apr 23, 2019
Copy link
Contributor

@rchao rchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 23, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 23, 2019
@tensorflow-copybara tensorflow-copybara merged commit 096d4f5 into tensorflow:master May 1, 2019
PR Queue automation moved this from Approved by Reviewer to Merged May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants