-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TF 2.0 docs] Add example for EarlyStopping #27838
Conversation
I think a short example like this is very useful for user who don't have much experience and want to use a callback for their first time.
If the responses are positive I will create examples for the other callbacks, too. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: aweers <32593524+aweers@users.noreply.github.com>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Co-Authored-By: aweers <32593524+aweers@users.noreply.github.com>
Co-Authored-By: aweers <32593524+aweers@users.noreply.github.com>
Co-Authored-By: aweers <32593524+aweers@users.noreply.github.com>
Thank you again @kyscg! I like the interactive style and will try to make the next examples in a similiar way! |
@rthadur, gentle ping to review and set CLA's to yes |
@aweers can you please sign CLA |
@rthadur I signed the CLA ;) |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please see the comments.
@rchao I updated the file with your suggestions |
But somehow I don't see a new commit? Only if I try to edit the file again, I see the changes I made... |
Thanks! I don't see it either. Please let me know once the commit is made. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you.
I think a short example like this is very useful for user who don't have much experience and want to use a callback for their first time.